Skip to content

add delete method on scoped_session#251

Open
burnettk wants to merge 1 commit intodropbox:masterfrom
burnettk:scoped-session-delete
Open

add delete method on scoped_session#251
burnettk wants to merge 1 commit intodropbox:masterfrom
burnettk:scoped-session-delete

Conversation

@burnettk
Copy link
Copy Markdown

@burnettk burnettk commented Oct 20, 2022

for this sort of code:

user = UserModel.query.filter_by(username="awesomeuser").first()
db.session.delete(user)  # type: ignore, until now
db.session.commit()

not sure if it's a new issue in some version of sqlalchemy. i'm on SQLAlchemy-1.4.42 and Flask-SQLAlchemy-3.0.2.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 20, 2022

CLA assistant check
All committers have signed the CLA.

@burnettk
Copy link
Copy Markdown
Author

Should this be merged? I have no idea if it is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants