Disable auto line ending conversion in Windows Dockerfiles#31
Open
aknuds1 wants to merge 2 commits intodrone:masterfrom
Open
Disable auto line ending conversion in Windows Dockerfiles#31aknuds1 wants to merge 2 commits intodrone:masterfrom
aknuds1 wants to merge 2 commits intodrone:masterfrom
Conversation
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
tboerger
approved these changes
Nov 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We (Grafana Labs) have been having test failures on Windows due to automatic conversion of line endings to CRLF on Windows. I tracked it down to being caused by the Git config parameter core.autocrlf being set to true in the Windows Docker image of the Drone Git plugin. This PR proposes to disable the parameter, so line endings aren't altered by Git on checkout.
I tested the image and it solves our issue.