Skip to content

Fix retrosheet ids to allow for short last names #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SushiInYourFace wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix retrosheet ids to allow for short last names #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bc/models/intermediate/bio/people.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ joined AS (

final AS (
SELECT
CASE WHEN person_id SIMILAR TO '[a-z]{5}[01][0-9]{2}' THEN person_id ELSE NULL END AS player_id,
CASE WHEN person_id SIMILAR TO '[-a-z]{5}[01][0-9]{2}' THEN person_id ELSE NULL END AS player_id,
*
FROM joined
)
Expand Down