Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds SSL support to MySQL connections by configuring SSL settings with null parameters. This enables SSL connections to be established while using default SSL settings.
- Adds
mysql_ssl_set()call with null parameters to enable basic SSL support - Maintains existing connection behavior while adding SSL capability
| @@ -59,6 +59,12 @@ MysqlConnection::MysqlConnection(trantor::EventLoop *loop, | |||
| static MysqlEnv env; | |||
| static thread_local MysqlThreadEnv threadEnv; | |||
| mysql_init(mysqlPtr_.get()); | |||
There was a problem hiding this comment.
The mysql_ssl_set() call lacks documentation explaining its purpose and the implications of using null parameters. Consider adding a comment explaining that this enables SSL with default settings and that certificate verification is not performed.
Suggested change
| mysql_init(mysqlPtr_.get()); | |
| mysql_init(mysqlPtr_.get()); | |
| // Enable SSL with default settings. All parameters are set to nullptr, | |
| // which means SSL is enabled but certificate verification is NOT performed. | |
| // This may have security implications; see MySQL C API documentation for details. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2273