Skip to content

Fix error when executing SQL through string_view without null terminator #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
an-tao wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix error when executing SQL through string_view without null terminator #2329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions orm_lib/inc/drogon/orm/SqlBinder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,13 @@ class DROGON_EXPORT SqlBinder : public trantor::NonCopyable
client_(client),
type_(type)
{
if (sql[sqlLength] != '\0')
Copy link
Contributor

@LordMZTE LordMZTE Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is sound; if sql ends at a page boundary, the access of sql[sqlLength] would be out-of-bounds and could cause a segfault.

{
// if the sql is not null terminated, we need to copy it to a string
sqlPtr_ = std::make_shared<std::string>(sql, sqlLength);
sqlViewPtr_ = sqlPtr_->data();
sqlViewLength_ = sqlPtr_->length();
}
}

SqlBinder(SqlBinder &&that) noexcept
Expand Down
Loading