add StreamReader cancel read steam#2232
Open
afx919 wants to merge 1 commit intodrogonframework:masterfrom
Open
add StreamReader cancel read steam#2232afx919 wants to merge 1 commit intodrogonframework:masterfrom
afx919 wants to merge 1 commit intodrogonframework:masterfrom
Conversation
Member
|
方向不对。 MultipartStreamParser 是用来解析字节流的,它不应该关心其他事情。这个修改直接打穿了所有的抽象层,完全不能接受。 这个修改并没有中断请求体的接收,也没有给客户端相应的应答。而且 MultipartStreamReader 只是 RequestStreamReader 的一个参考实现,只修改它是没有意义的。 正确的思路应该是给 RequestStreamReader 添加一个 abort 方法。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dataCb增加bool返回值用于取消接收