Conversation
| poolPtr->wait(); | ||
| poolPtr.reset(); | ||
| }; | ||
| (func(args), ...); |
There was a problem hiding this comment.
The thread pool may not created by HttpClientPool, we should not quit thread pool unconditionally.
| dispatchPool_ = std::make_shared<trantor::EventLoopThreadPool>(1); | ||
| dispatchPool_->start(); | ||
| } | ||
| loopPtr_ = dispatchPool_->getNextLoop(); |
There was a problem hiding this comment.
What does dispatchPool_ do? I only see one loop use here.
|
@hwc0919 @marty1885 please check |
|
@nqf Sorry Things cam up and I'm very busy at work RN. Will check sometime this week, most likely the weekends. From an initial look, I've concerns of this interacting unfavorably with our HTTP/2 client (you shouldn't pool HTTP/2). |
yes, this is a client connection pool for http1.1, and i think http2 should not need it. http2 has not been merged into master yet |
fantasy-peak
force-pushed
the
pool
branch
3 times, most recently
from
2fc63f6 to
0229064
Compare
4 participants
No description provided.