orchestrate: harden generated Workflow script against args-as-string#320
Merged
Conversation
The Workflow runtime can deliver `args` to the generated script as a JSON string rather than an object, which made `args.groups` undefined and crashed the workflow on launch. Normalize with a JSON.parse fallback and read all fields off the normalized object. Also document that `args` is not persisted across resumes and must be re-passed on every Workflow invocation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Workflow runtime can deliver
argsto the generated script as a JSON string rather than an object, which madeargs.groupsundefined and crashed the workflow on launch.const A = typeof args === 'string' ? JSON.parse(args) : argsand read all fields offA.argsmust be passed on every Workflow invocation, including resumes (it is not persisted across runs).Co-Authored-By: Claude noreply@anthropic.com