logo: inline SVGs in comparison page for Argus artifact rendering#318
Merged
Conversation
The Step-3 comparison template used relative <img src="logo-alt-N.svg">, which renders locally but breaks when the page is registered as an Argus artifact (strict CSP, no relative-path resolution) — every mark showed as a broken image. Inline each SVG once as a hidden <symbol> and render via <use> at both well-size and a ~36px avatar size (dark + light), so one page works in both contexts. - Namespace SVG ids per logo to avoid gradient/filter collisions on inline - Add optional Argus artifact-register step for mobile review - Add Step-5 PNG-export note: sips can't do SVG→PNG; use rsvg-convert, resvg, or ImageMagick convert -density 384 -background none 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…ionale - Step 4b now uses the inlined <symbol>/<use> template (was silently reintroducing the <img src> broken-image bug for variant pages) - Reword width/height rationale: it's for standalone file viewing, not <img> rendering (which Step 3 now forbids) - Namespacing rule: rename both the id AND its url(#id) references - Note <use> shadow-tree CSS caveat: style with attributes, not classes - Explain the -density 384 magic number inline 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the /logo skill's comparison-page template to inline SVGs via![]()
, which breaks when the page
/ instead of relative
is registered as an Argus artifact (strict CSP, no relative-path
resolution). Render each mark at both well-size and a ~36px avatar size
(dark + light) since small-size legibility is the real selection test.
resvg, or ImageMagick
Co-Authored-By: Claude noreply@anthropic.com