Fix BUG-013: empty-plan state when no plan authored (no live-role pseudo-DAG)#811
Merged
Conversation
…udo-DAG)
When a coordinator has no authored plan (no planned nodes, no hera_blocks edges),
the Plan pane now renders an empty-plan placeholder ("No plan authored." + an
authoring hint) instead of drawing the live worker roles as a flat pseudo-DAG
stage. The live agents stay visible in the rail.
The empty-vs-DAG decision lives in the hera layer (HeraPage.rebuildPlan gates on
the new planIsAuthored helper and feeds the widget an empty node set when no plan
is authored); the projection heraPlanNodesWithBridge is unchanged and still
surfaces live worker nodes for the plan-authored case. The planview widget stays
a generic node renderer; its empty-node-set placeholder text was improved.
Adds page + widget + smoke tests for the empty-state and the still-rendered DAG;
OpenSpec hera-view delta modifies the Plan-DAG requirement accordingly.
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Plan pane fell back to rendering live worker roles as a flat edgeless single stage ("no plan authored — live roles:") when an orchestrator had no authored plan — depicting ad-hoc managed agents as if they were a plan-DAG, which contradicts the model (DAG = the authored plan; rail = the agent roster).
Fix
When an orchestrator has no authored plan — zero planned nodes (
RoleView.Planned) and zerohera_blocksedges — the Plan pane now renders an empty-plan state ("No plan authored" + author hint) instead of the live-role stage. When a plan is authored (≥1 planned node or edge), the full DAG renders exactly as before (planned + live nodes + edges, with #795 cancelled/failed states, BUG-010 scroll, BUG-011 wrap, BUG-012 sync — none regressed). Live agents remain in the rail untouched.Tests / spec
--new-from-rev→ 0 issues;go test ./internal/tui/hera/ ./internal/tui/planview/ ./internal/tui/green; build + gofmt clean.fix-bug-013-no-plan-empty-state(hera-view delta replacing the old live-role-fallback contract, validates --strict); plan.go comment + gotcha updated.🤖 Generated with Claude Code