Hera-managed tasks visible in task list by default + worker indicator#807
Open
drn wants to merge 1 commit into
Open
Hera-managed tasks visible in task list by default + worker indicator#807drn wants to merge 1 commit into
drn wants to merge 1 commit into
Conversation
Flip the `H` hide-hera toggle to default OFF so hera-spawned workers and live coordinators show inline in the Tasks tab instead of being hidden. Add a per-row worker indicator glyph (theme.IconWorker) alongside the existing coordinator glyph; coordinator outranks worker when a task is both. `H` still toggles, now to *hide* rather than reveal. Archives the hera-tasks-visible-by-default openspec change into the task-list-view base spec. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Collaborator
|
SGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hhide-hera toggle to default OFF: hera-spawned workers and live coordinators are now visible inline in the Tasks tab instead of hidden.Hstill toggles — it now hides them rather than revealing.theme.IconWorker, dim account glyph) in the hera-role indicator cell, alongside the existing coordinator glyph. Coordinator outranks worker when a task qualifies as both.Why
Hera-managed tasks living only in the Hera tab made a chunk of live work invisible on the primary navigation surface — you had to remember to press
Hto see workers a coordinator spawned. Making them visible-by-default only reads well once workers are also visually marked, hence the worker glyph (coordinators already had one).Test plan
make pre-pr: build / vet / fmt-check / lint-pr pass;test-cover-gategreen at 89.5% ≥ 88 floor (taskview 94.8%, theme 100%).vulnreports Go stdlib-only CVEs (toolchain version), which runcontinue-on-error: truein CI and don't block — fails identically on a cleanorigin/master.VisibleTaskIDs()includes workers + coordinators by default;Hhides them; freelancer/plain always visible; composes with the substring filter. Smoke test (TestSmoke_HideHeraWorkersInTasksTab) updated to the new default.Notes
hera-tasks-visible-by-defaultopenspec change into thetask-list-viewbase spec in the same PR.Htext ("show/hide hera-managed (workers+coords)") stays accurate — no key added/removed.hera-handoff-associationopenspec proposal exists locally but is intentionally excluded from this PR: it's unimplemented and its design is being revised (lightweight task-edge model vs. coordinator auto-promotion).🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com