Open Link picker: mark PR links in TUI + webapp#804
Merged
Conversation
Pull-request URLs are usually the link the user is hunting for, but in the Open Link picker they look identical to CI links, docs, and references. Mark them so the most actionable link is scannable at a glance. - internal/links: add IsPR(url) (GitHub /pull/<n>, GitLab /merge_requests/<n>, matched by path so GHE / self-hosted GitLab count too) and an IsPR field on Link, stamped by Extract — single source of truth, clients never re-derive. - TUI: both pickers (simple + ctrl+l fuzzy) draw a git-pull-request glyph before PR rows; every row reserves a 2-col gutter so rows stay aligned. - Webapp: Open Link modal renders a purple "PR" badge before PR rows from the server's isPR field (DOM API, no innerHTML). Bump SW_VERSION v61->v62. - Routed through OpenSpec (add-pr-link-indicator), archived with base specs merged. Tests + gotcha notes added. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…s, honest IsPR test table - theme: StylePRLink = StylePRAwaiting (structural identity, not prose) so a future restyle of the PR purple moves both surfaces together. - pickers: comment why textW needs no clamp on narrow terminals (DrawText early-returns on non-positive width, SetContent clips) — closes the asymmetry with the filter row's fieldW clamp. - links_test: assert IsPR in the TestExtract loop and stamp IsPR:true on the PR-URL want entries so the table matches real output. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Captured from this session: openspec validate parses the requirement statement as text up to the first blank line and requires SHALL/MUST on the first physical line, so wrapping SHALL onto line 2 fails validation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
drn
force-pushed
the
argus/In-the-open-link-modal-in-tui
branch
from
90997e7 to
5ee37ad
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark pull-request URLs in the Open Link picker so the most actionable link
is scannable at a glance, in both the TUI and the web client.
/merge_requests/, matched by path so GHE / self-hosted GitLab count)
stamps an IsPR field on each extracted Link — single source of truth.
reserves a 2-col gutter so rows stay column-aligned.
server's isPR field (DOM API, no innerHTML). SW_VERSION bumped to v63.
merged. Tests + gotcha notes added.
Co-Authored-By: Claude noreply@anthropic.com