fix(drizzle-kit): handle MySQL functional/expression indexes in introspection#5548
Open
cyphercodes wants to merge 1 commit intodrizzle-team:mainfrom
Open
fix(drizzle-kit): handle MySQL functional/expression indexes in introspection#5548cyphercodes wants to merge 1 commit intodrizzle-team:mainfrom
cyphercodes wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
…spection MySQL 8+ functional indexes have COLUMN_NAME = null in INFORMATION_SCHEMA.STATISTICS with the actual expression stored in the EXPRESSION column. This caused drizzle-kit pull to crash with 'Cannot read properties of null (reading camelCase)' when introspecting databases with functional indexes. Changes: - mysqlSerializer.ts: Check for null COLUMN_NAME and use EXPRESSION column instead - mysqlSerializer.ts: Track expression columns in internals.indexes for TS generation - introspect-mysql.ts: Handle expression columns by wrapping in sql`...` instead of table.column Fixes drizzle-team#5546
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
MySQL 8+ functional indexes have
COLUMN_NAME = nullinINFORMATION_SCHEMA.STATISTICSwith the actual expression stored in theEXPRESSIONcolumn. This causeddrizzle-kit pullto crash with:when introspecting databases with functional/expression indexes.
Changes
mysqlSerializer.ts
COLUMN_NAMEand useEXPRESSIONcolumn instead for functional indexesinternals.indexesfor proper TypeScript generationCOLUMN_NAMEandEXPRESSIONare nullintrospect-mysql.ts
createTableIndexesandcreateTableUniquesto accept schema parametersql\...`instead oftable.column`Example
Before (crash):
After (works):
Testing
This fix was tested against the reproduction case provided in #5546.
Fixes #5546