feat(expo-sqlite): add optional async driver#5533
Open
maxencehenneron wants to merge 1 commit intodrizzle-team:mainfrom
Open
feat(expo-sqlite): add optional async driver#5533maxencehenneron wants to merge 1 commit intodrizzle-team:mainfrom
maxencehenneron wants to merge 1 commit intodrizzle-team:mainfrom
Conversation
The existing expo-sqlite driver operates in sync mode, which blocks the UI thread and does not work on web. This adds a new async driver at `drizzle-orm/expo-sqlite/async` that uses expo-sqlite's async APIs (executeAsync, getAllAsync, getFirstAsync, executeForRawResultAsync). The existing sync driver is completely unchanged for backward compatibility.
Author
|
fixes #5240 |
|
Hi @maxencehenneron |
|
looks like you didnt take into account some palces of code that also should be fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing expo-sqlite driver operates in sync mode, which blocks the UI thread and does not work on web (using react-native-web).
This adds a new async driver at
drizzle-orm/expo-sqlite/asyncthat uses expo-sqlite's async APIs (executeAsync, getAllAsync, getFirstAsync, executeForRawResultAsync).The existing sync driver is completely unchanged for backward compatibility.
Usage