fix: validate transaction behavior to prevent SQL injection in SQLite sessions (#5512)#5526
Open
guoyangzhen wants to merge 3 commits intodrizzle-team:mainfrom
Open
fix: validate transaction behavior to prevent SQL injection in SQLite sessions (#5512)#5526guoyangzhen wants to merge 3 commits intodrizzle-team:mainfrom
guoyangzhen wants to merge 3 commits intodrizzle-team:mainfrom
Conversation
Author
|
Hi, just checking in on this PR. Happy to make any changes if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Closes #5512
📝 Description
The
config.behaviorfield is directly interpolated intosql.raw()without validation in SQLite session files:If user input flows into
SQLiteTransactionConfig.behavior, it goes straight into raw SQL. SQLiteBEGINonly acceptsDEFERRED,IMMEDIATE, orEXCLUSIVE— anything else should be rejected.Changes
Added whitelist validation in all three affected files:
drizzle-orm/src/sql-js/session.tsdrizzle-orm/src/expo-sqlite/session.tsdrizzle-orm/src/d1/session.tsEach file now has:
The validated output is used instead of raw interpolation:
Why this matters
While
behavioris typically a developer-controlled config value, defense-in-depth is important. A validation layer prevents:The throw provides a clear error message rather than letting invalid SQL reach the database.