Skip to content

fix: generate one() instead of many() for one-to-one relations with unique FK #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: generate one() instead of many() for one-to-one relations with unique FK #5480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions drizzle-kit/src/cli/commands/introspect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,6 +766,7 @@ export const relationsToTypeScript = (
onDelete?: string | undefined;
}
>;
uniqueConstraints?: Record<string, string[]>;
}
>;
},
Expand Down Expand Up @@ -821,9 +822,15 @@ export const relationsToTypeScript = (
tableRelations[keyTo] = [];
}

// Check if the FK column has a unique constraint (one-to-one relationship)
const tableUniqueConstraints = table.uniqueConstraints || {};
const hasUniqueConstraint = Object.values(tableUniqueConstraints).some(
(uniqueCols) => uniqueCols.length === 1 && uniqueCols[0] === fk.columnsFrom[0],
);

tableRelations[keyTo].push({
name: plural(tableFrom),
type: 'many',
name: hasUniqueConstraint ? singular(tableFrom) : plural(tableFrom),
type: hasUniqueConstraint ? 'one' : 'many',
tableFrom: tableTo,
columnFrom: columnTo,
tableTo: tableFrom,
Expand Down