Skip to content

Ensure valid unclaimed ORCID iDs in drip lists are returned #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhgbrown merged 1 commit into from
Dec 17, 2025
Merged

Ensure valid unclaimed ORCID iDs in drip lists are returned #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions src/drip-list/dripListResolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,17 @@ import verifyDripListsInput from './dripListValidators';
import type { DripListDataValues } from './DripListModel';
import { resolveTotalEarned } from '../common/commonResolverLogic';
import { toResolverProject } from '../project/projectUtils';
import { chainToDbSchema } from '../utils/chainSchemaMappings';
import { chainToDbSchema, dbSchemaToChain } from '../utils/chainSchemaMappings';
import { getLatestMetadataHashOnChain } from '../utils/getLatestAccountMetadata';
import groupBy from '../utils/linq';
import getUserAddress from '../utils/getUserAddress';
import toGqlLinkedIdentity from '../linked-identity/linkedIdentityUtils';
import toGqlLinkedIdentity, {
toFakeUnclaimedOrcid,
} from '../linked-identity/linkedIdentityUtils';
import {
extractOrcidFromAccountId,
isOrcidAccount,
} from '../orcid-account/orcidAccountIdUtils';

const dripListResolvers = {
Query: {
Expand Down Expand Up @@ -268,6 +274,25 @@ const dripListResolvers = {
);

if (!identity) {
// an ORCID iD was added to the drip list, but no identity was found
// in the database. This can happen if the ORCID iD was added to the
// to the drip list before it was claimed.
if (isOrcidAccount(s.receiverAccountId)) {
return {
...s,
driver: Driver.REPO,
account: {
driver: Driver.REPO,
accountId: s.receiverAccountId,
},
linkedIdentity: toFakeUnclaimedOrcid(
extractOrcidFromAccountId(s.receiverAccountId),
s.receiverAccountId as unknown as RepoDriverId,
dbSchemaToChain[dripListChain],
),
};
}

return shouldNeverHappen('Expected linked identity to exist');
}

Expand Down