Conversation
…nous - Introduced a new `.python-version` file specifying Python version 3.10.11. - Modified `unsubscribe` method in `DriftUserStats` class to be asynchronous, ensuring it properly awaits the `unsubscribe` call from `account_subscriber`. - Updated `UserStatsMap` class to await the `unsubscribe` method of `existing_drift_user_stat` when it exists. - Enhanced VSCode settings to include additional paths for Python analysis.
SinaKhalili
reviewed
Jun 24, 2025
Contributor
SinaKhalili
left a comment
SinaKhalili
left a comment
There was a problem hiding this comment.
Just a couple noticed some codepaths that the subscribe change being async might affect, lmk if you find any others. Otherwise, looks good 👍🏽
|
|
||
| if existing_drift_user_stat: | ||
| existing_drift_user_stat.unsubscribe() | ||
| await existing_drift_user_stat.unsubscribe() |
Contributor
There was a problem hiding this comment.
I think there might be more places to put await if we change unsubscribe to async
Contributor
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.python-versionfile specifying Python version 3.10.11.unsubscribemethod inDriftUserStatsclass to be asynchronous, ensuring it properly awaits theunsubscribecall fromaccount_subscriber.UserStatsMapclass to await theunsubscribemethod ofexisting_drift_user_statwhen it exists.