Fix: Use Xcode diagnostic format patterns to avoid false positive error counts#4
Merged
drewster99 merged 1 commit intomainfrom Jan 9, 2026
Merged
Conversation
…or counts The previous regex patterns matched "error:" and "warning:" with word boundaries, which caused false positives from: - Objective-C method parameters like error:(NSError**)error - Code snippets in warning messages containing method signatures Updated patterns now match only: - file:line:column: error: (typical compiler diagnostic format) - ^error: at start of line (standalone errors like linker errors) This prevents false positives while catching all actual Xcode build errors. Fixes #2 Co-authored-by: Andrew Benson <drewster99@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
The previous regex patterns matched "error:" and "warning:" with word boundaries, which caused false positives from:
error:(NSError**)errorUpdated patterns now match only:
file:line:column: error:(typical compiler diagnostic format)^error:at start of line (standalone errors like linker errors)This prevents false positives while catching all actual Xcode build errors.
Generated with Claude Code