Skip to content

Conversation

@GangGreenTemperTatum
Copy link
Collaborator

@GangGreenTemperTatum GangGreenTemperTatum commented Feb 6, 2025

addresses errors identified in false positive reporting -> example #31 (comment) and #32

AI-Generated Summary

  • Updated YAML formatting for the paths in the GitHub Actions workflow file.
  • Adjusted string quotes from single to double for consistency in validate_robopages.yml.
  • Set continue-on-error: true for the validation step to allow the workflow to proceed even if initial validations fail.
  • Modified environment variable for post-validation status to ensure it's derived from the validation step's outcome.
  • Enhanced the final status message to provide clearer feedback based on validation results.
  • Overall, these changes improve the workflow's robustness and clarify the validation feedback process for contributors.

This summary was generated with ❤️ by rigging

@GangGreenTemperTatum GangGreenTemperTatum merged commit 982ce52 into main Feb 6, 2025
1 check passed
@GangGreenTemperTatum GangGreenTemperTatum deleted the ads/eng-1009-robopages-validation-workflow-is-reporting-fps branch February 6, 2025 12:46
@GangGreenTemperTatum
Copy link
Collaborator Author

yay! #32 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants