Skip to content

fix: Synchronous Pipeline Callbacks#183

Merged
monoxgas merged 1 commit intomainfrom
fix/sync-pipeline-callbacks
Jul 7, 2025
Merged

fix: Synchronous Pipeline Callbacks#183
monoxgas merged 1 commit intomainfrom
fix/sync-pipeline-callbacks

Conversation

@monoxgas
Copy link
Copy Markdown
Contributor

@monoxgas monoxgas commented Jul 2, 2025

Notes

  • Removing explicit checks for async then/map/watch callbacks

Generated Summary

  • Removed explicit async function checks in callback iterations for the "map", "then", and ChatPipeline methods, simplifying callback registration.
  • Updated type annotations in protocol definitions (_ThenChatCallback and _MapChatCallback) to accept both Awaitable and direct returned values.
  • Adjusted _wrap_watch_callback to capture the callback result and conditionally await it if necessary.
  • Modified test for message slicing to assert that an "Empty string target provided" warning is raised when slicing with an empty string.

This summary was generated with ❤️ by rigging

@monoxgas monoxgas requested a review from a team as a code owner July 2, 2025 23:13
@dreadnode-renovate-bot dreadnode-renovate-bot bot added area/docs Changes to documentation and guides area/tests Changes to test files and testing infrastructure type/docs Documentation updates and improvements labels Jul 2, 2025
@monoxgas monoxgas merged commit 442cde8 into main Jul 7, 2025
7 checks passed
@monoxgas monoxgas deleted the fix/sync-pipeline-callbacks branch July 7, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Changes to documentation and guides area/tests Changes to test files and testing infrastructure type/docs Documentation updates and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant