Skip to content

fix(ssms): improve SSMS installation check and command parameters#343

Open
Ne0nd0g wants to merge 1 commit into
dreadnode:mainfrom
Ne0nd0g:fix/smss-install
Open

fix(ssms): improve SSMS installation check and command parameters#343
Ne0nd0g wants to merge 1 commit into
dreadnode:mainfrom
Ne0nd0g:fix/smss-install

Conversation

@Ne0nd0g

@Ne0nd0g Ne0nd0g commented Jul 10, 2026

Copy link
Copy Markdown

Summary

Fixes SQL Server Management Studio (SSMS) installation on newer Windows hosts by improving installation detection and updating the installer invocation to match the behavior of current SSMS releases.

These changes make the installation process more reliable across fresh GOAD deployments while remaining backwards compatible with existing lab provisioning.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would change existing behavior)
  • New lab, lab variant, or extension
  • New / updated provider support
  • Refactor / internal cleanup (no functional change)
  • Documentation
  • CI / build / release tooling
  • Dependency update

Area

  • CLI (cli/)
  • Ansible collection (ansible/)
  • Terraform / Terragrunt (infra/, modules/)
  • Packer / Warpgate (packer/, warpgate-templates/)
  • Lab definitions (ad/)
  • Extensions (extensions/)
  • Variant generator / tools (tools/)
  • Documentation (docs/, README.md, etc.)
  • CI workflows (.github/)

Related issues

Related to the SQL Server Management Studio installation issues discussed in Orange-Cyberdefense/GOAD#480.

How was this tested?

  • Verified provisioning successfully installs SSMS when it is not already present.

  • Verified existing SSMS installations are detected correctly and skipped.

  • Confirmed the updated installer command executes successfully with the current Microsoft SSMS bootstrapper.

  • Provider(s) tested: Hyper-V

  • Lab(s) tested: GOAD

  • Operator OS: Linux (Ansible control host)

Screenshots / logs (optional)

N/A

Checklist

  • I have read CONTRIBUTING.md.
  • My changes follow the existing code style of the area I touched.
  • I have added or updated tests where it makes sense (manual provisioning validation).
  • I have updated documentation (README, docs/, role README, command help text) where relevant.
  • I have checked that I am not committing real secrets, personal credentials, or internal hostnames. (Intentional lab credentials inside ad/, ansible/, and extensions/ are expected and fine.)
  • If this PR changes user-facing CLI behavior, I have updated the relevant --help text and any docs that reference it.
  • If this PR introduces a breaking change, I have called it out in the Summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/roles Changes made to Ansible roles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant