Fix/variant generator fidelity#342
Open
Ne0nd0g wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several variant-generator fidelity issues that could leave generated labs referencing stock GOAD assets, retain original identity names, or omit required empty directories.
Generated variants now handle CamelCase name components, rename identity-based files consistently with their contents, use and rewrite variant-specific inventory templates, and preserve
.gitkeepplaceholders when copying the lab tree.Type of change
Area
cli/)ansible/)infra/,modules/)packer/,warpgate-templates/)ad/)extensions/)tools/)docs/,README.md, etc.).github/)Related issues
N/A
How was this tested?
Added table-driven Go tests covering name-component replacement at:
StarkWallpaperAdded negative cases confirming that partial identifiers such as
Starkey,Stark1,Stark_svc, andaStarkare not changed.Verified that generated variant inventories are sourced from the variant tree and that their
domain_namevalues point to the generated variant.Verified that identity-based filenames are transformed using the same mappings as their contents.
Verified that
.gitkeepfiles are retained so required empty directories remain present in generated variants.Provider(s) tested:
Lab(s) tested:
Operator OS: Linux
Screenshots / logs (optional)
N/A
Checklist
cli/, Ansible syntax checks, etc.).docs/, role README, command help text) where relevant.ad/,ansible/, andextensions/are expected and fine.)--helptext and any docs that reference it.