Skip to content

Fix homepage feature links (404s and wrong URL) #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alienx5499 wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −2
Open

Fix homepage feature links (404s and wrong URL) #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion docs/.vuepress/theme/components/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,14 @@
<p>{{ feature.details }}</p>
<div v-if="feature.actions && feature.actions.length" class="actions">
<template v-for="(action, index) in feature.actions">
<router-link :to="action.link" class="action-button">{{
<a
v-if="isExternal(action.link)"
:href="action.link"
class="action-button"
target="_blank"
rel="noopener noreferrer"
>{{ action.text }}</a>
<router-link v-else :to="action.link" class="action-button">{{
action.text
}}</router-link>
</template>
Expand Down Expand Up @@ -67,6 +74,16 @@ export default {
text: this.data.actionText
}
}
},

methods: {
// only treat as external when link is clearly a full URL
// relative paths still use router link
isExternal(link) {
if (typeof link !== 'string') return false
const trimmed = link.trim()
return trimmed.startsWith('http://') || trimmed.startsWith('https://')
}
}
}
</script>
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ features:
details: Get your randomness or chain information directly by sending HTTP `GET` requests to the drand JSON HTTP API.
actions:
- text: API docs
link: /developer/http-api
link: https://docs.drand.love/dev-guide/developer/http-api
- title: Client libraries
details: Use drand client libraries to easily consume randomness from your applications, over HTTP, gRPC or libp2p PubSub.
actions:
Expand Down