Bumped dependencies and addressed some of linter findings#64
Merged
AnomalRoil merged 4 commits intodrand:fix/go-v1.23from Nov 10, 2025
Merged
Bumped dependencies and addressed some of linter findings#64AnomalRoil merged 4 commits intodrand:fix/go-v1.23from
AnomalRoil merged 4 commits intodrand:fix/go-v1.23from
Conversation
AnomalRoil
requested changes
Nov 10, 2025
Member
AnomalRoil
left a comment
AnomalRoil
left a comment
There was a problem hiding this comment.
Nice, thanks a lot. If you could just re-add the code needed for the amd64 targets to compile, then that should be good to go.
| "golang.org/x/sys/cpu" | ||
| ) | ||
|
|
||
| var hasBMI2 = cpu.X86.HasBMI2 |
Member
There was a problem hiding this comment.
this is needed for gfp_amd64.s to compile
| module github.com/drand/kyber | ||
|
|
||
| go 1.18 | ||
| go 1.25 |
Member
There was a problem hiding this comment.
Could we have the lowest version as required by dependencies rather than the latest one?
I suspect go 1.23 or go 1.24 should suffice.
Merged
AnomalRoil
added a commit
that referenced
this pull request
Nov 10, 2025
* Bumped dependencies and addressed some of linter findings (#64) * bump golang version * Modernization * Update Go version requirement and testing command * integrated changes from pr 62 * Fixing tests and keeping lower go version --------- Co-authored-by: Andrei Smirnov <pinebit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-race