Improve routes, auth, and middleware test coverage#24
Open
alienx5499 wants to merge 1 commit intodrand:masterfrom
Open
Improve routes, auth, and middleware test coverage#24alienx5499 wants to merge 1 commit intodrand:masterfrom
alienx5499 wants to merge 1 commit intodrand:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase test coverage around HTTP routing, JWT auth, and common middleware in the HTTP relay. This PR adds focused tests that lock in existing behavior for route listing, auth error handling, and default headers/log level, making future changes safer.
Changes
routes_test.goTestDisplayRoutes_FiltersAndFallsBackto cover:/v2only shows v2 routes).404while still returning a plain-text list of routes.TestDisplayRoutes_HeadersAndOrderto cover:Content-Typeistext/plain; charset=utf-8andX-Content-Type-Optionsisnosniff.auth_test.goTestAddAuth_MissingHeader: noAuthorizationheader →401with"Missing JWT\n"body.TestAddAuth_InvalidToken: malformed JWT inAuthorizationheader →401with"Invalid JWT\n"body.middleware_test.goTestAddCommonHeaders: verifiesaddCommonHeaderssets:Serverto the currentversion.Content-Typetoapplication/json.Access-Control-Allow-Originto*.TestGetLogLevel: ensuresgetLogLevelreturns:INFOwhen-verboseis false.DEBUGwhen-verboseis true.Checklist
go test ./...passes indrand/http-relay