Add error handling for HTTP response writes#21
Open
alienx5499 wants to merge 2 commits intodrand:masterfrom
Open
Add error handling for HTTP response writes#21alienx5499 wants to merge 2 commits intodrand:masterfrom
alienx5499 wants to merge 2 commits intodrand:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Multiple HTTP handlers call
w.Write()without checking the returned error. Write failures are silently ignored, making it difficult to debug network issues or client disconnections.Affected handlers:
writeBeacon(),GetChains(),GetHealth(),GetBeaconIds(),GetInfoV1(),GetInfoV2()inroutes_handler.goDisplayRoutes()inroutes.go/chanzhandler inmetrics.goSolution
Added error checking and logging for all
w.Write()calls. Since HTTP headers may have already been sent when a write error occurs, we log the error but do not attempt to return an HTTP error status.Changes
w.Write()in all HTTP handlersTesting