Expose catchup_period_seconds in /info JSON (Closes drand#1176)#16
Open
alienx5499 wants to merge 1 commit intodrand:masterfrom
Open
Expose catchup_period_seconds in /info JSON (Closes drand#1176)#16alienx5499 wants to merge 1 commit intodrand:masterfrom
alienx5499 wants to merge 1 commit intodrand:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
catchup_period_secondsfield to the/infoJSON endpoint to help clients, relays, dashboards, and SREs reason about expected pacing during catchup without guessing from network behavior.Changes
CatchupPeriodSeconds uint32field toJsonInfoV2struct ingrpc/grpc.goChainInfoPacketprotobuf (backward compatible)catchup_period_secondsAPI Example
{ "public_key": "<hex>", "period": 3, "genesis_time": 1692803367, "chain_hash": "<hex>", "scheme": "bls-unchained-g1-rfc9380", "beacon_id": "default", "catchup_period_seconds": 1 }Backward Compatibility
Additive JSON field only. No runtime behavior changes. Works with current protobuf versions (returns 0 if field not present) and will automatically populate once drand protobuf is updated.
Closes drand/drand#1176