Skip to content

Conversation

@dragonsinth
Copy link
Owner

@dragonsinth dragonsinth commented Feb 10, 2024

Notes

  • it was a little confusing that the file_requests API doesn't work, you have to use the file APIs

    • for example, you can't use list you have to use list_folder
  • "between 2000 and 5000 words"

    • a little more precision here would be nice... what defines a word, exactly?
    • I considered checking each token (post split) for upper and lower alpha chars,
      and only counting "words" that contain an alpha, but this seemed overkill for
      this problem.
  • "Consider how to test..."

    • Tricky, considering most of this code is written against live APIs
    • Manual testing is really the most reliable way to test against live services
    • If document processing were more complex than a simple word count, we'd definitely
      want to test that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants