build: update vendored six from 1.11.0 to 1.16.0#2398
build: update vendored six from 1.11.0 to 1.16.0#2398wbarnha merged 1 commit intodpkp:masterfrom shifqu:fix/2282-importwarning
Conversation
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
| import io | ||
| StringIO = io.StringIO | ||
| BytesIO = io.BytesIO | ||
| del io |
There was a problem hiding this comment.
A new del statement. Does the same condition here apply as in #979 (comment)?
|
kafka-python 2.0.2 doesn't work anymore (a |
|
Thank you for the PR, sorry I didn't notice this sooner. I was hoping for a release of v2.0.3 before pulling in changes such as this. If the workflows pass, I'll approve. |
wbarnha
left a comment
There was a problem hiding this comment.
It doesn't fix the 3.12 tests entirely, but nevertheless a step in the right direction. The failing async test is a separate issue. Approved!
|
@wbarnha , can this not get merged without the tests passing, even though the error is unrelated? |
|
Thanks for the Pull Request, I am also waiting for the solution so kafka-python works with Python 3.12.0 |
|
Sure, I'll make an exception to merge this. |
|
Any chance of getting a point release for this change soon? |
|
I'll reach out to Dana to see if I can get the ball rolling! |
|
Hi, Sorry for jumping on this closed thread, I found it after hitting a similar import issue with six after upgrading to python 3.12 ;) Are there still currently some blocking points preventing to use this package on python 3.10 to 3.12 ? I see that the six package was just one issue, but they might be others (at least for python 3.12). |
Not that I know of. Since all tests are now passing for 3.12, I don't see any immediate reason why this wouldn't work. But I should note I personally have not used this on 3.12. |
I have successfully used the library with Python 3.11 on Windows in the last release available from pip. |
|
Ok, so I will wait for a release to be cut and published through PyPi then. Thanks for your work ;) |
|
I apologize for taking so with long with this release. I'm still waiting to hear back from the maintainer. You can directly install from this repository via |
|
@wbarnha Just arrived here after a short journey that took me via https://blog.pecar.me/six-warnings Could you given an update as to when a release surpassing the current 2020 version 2.0.2 of kafka-python can be expected? |
|
Hi there, I'm waiting for PyPi credentials. Until then, I am powerless. We have been trying to get in contact with the author, but he has been unresponsive again. |
|
@wbarnha Thank you for your reply. Glad to hear you keep trying! |
|
Still trying. Thanks for your patience. 🥲 |
|
Hi there, |
|
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
…to-1.16.0 build: update vendored six from 1.11.0 to 1.16.0 (dpkp#2398)
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
|
I would also like to 👍 releasing this as I just saw this today in a clean install of ubuntu noble and would prefer to not switch to the other package if this one can be fixed |
|
Hello - I am running in the |
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
closes #2282
This change is