Merged
Conversation
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to stay up to date. Also, we will likely start vendoring `enum34` in which case benjaminp/six#178 is needed. Note that this preserves the `kafka-python` customization from #979 which has been submitted upstream as benjaminp/six#176 but not yet merged.
jeffwidman
force-pushed
the
bump-vendored-six-to-1.11.0
branch
from
b88c5f6 to
40e3aa9
Compare
dpkp
reviewed
Oct 23, 2018
| # Don't del it here, cause with gc disabled this "leaks" to garbage | ||
| # Don't del it here, cause with gc disabled this "leaks" to garbage. | ||
| # Note: This is a kafka-python customization, details at: | ||
| # https://github.com/dpkp/kafka-python/pull/979#discussion_r100403389 |
Owner
There was a problem hiding this comment.
fwiw -- if upstream doesn't want to merge this change, I don't think we should keep it.
Contributor
Author
There was a problem hiding this comment.
Agreed. I left a comment on the upstream PR to bump it so we'll see what happens...
Owner
|
to the future! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
sixto1.11.0. Most changes do not affect us, but it's good tostay up to date. Also, we will likely start vendoring
enum34in whichcase benjaminp/six#178 is needed.
Note that this preserves the
kafka-pythoncustomization from #979which has been submitted upstream as benjaminp/six#176 but not yet merged.
This change is