Skip to content

fixing bug due to updated cat files#2

Open
jsemple19 wants to merge 4 commits intodphiggs01:masterfrom
jsemple19:master
Open

fixing bug due to updated cat files#2
jsemple19 wants to merge 4 commits intodphiggs01:masterfrom
jsemple19:master

Conversation

@jsemple19
Copy link

@jsemple19 jsemple19 commented Apr 15, 2021

A few suggested fixes:
Necessary ones:

  1. There was a bug in the worm_cat_fun since the default value was an annotation file that no longer existed in the package data. I updated the default in the function and also modified the code so that if the file is not found in the package data, it will treat the file name as a path to a file outside the package. This makes it possible to use more up to date files or even custom files.
  2. The function documentation was confusing as it referred to "Wormbase ID" and "Sequence ID" but if you don't use "Wormbase.ID" or "Sequence.ID" then the table join breaks.

Useful ones:
3) worm_cat_fun will not try to create the output_dir unless it doesn't exist - makes it easier to rerun jobs and overwrite results.
4) added option to worm_cat_fun to turn off creating a zipped archive (default behavior is the same as before)

Fixing bug with annotation file not being same as inst/data. Default is now NULL to allow download of most up to date file. Fixing bug in documentation because "Wormbase ID" and "Sequence ID" should have a "." to make table join work. Making output directory creation dependant on it not existing to allow results to be overwritten with fresh run rather than crashing. Making zipped files optional (default behavior is the same as before).
If file is not in internal package data, will assume this is an absolute file path to the annotation file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant