fixing bug due to updated cat files#2
Open
jsemple19 wants to merge 4 commits intodphiggs01:masterfrom
Open
Conversation
Fixing bug with annotation file not being same as inst/data. Default is now NULL to allow download of most up to date file. Fixing bug in documentation because "Wormbase ID" and "Sequence ID" should have a "." to make table join work. Making output directory creation dependant on it not existing to allow results to be overwritten with fresh run rather than crashing. Making zipped files optional (default behavior is the same as before).
If file is not in internal package data, will assume this is an absolute file path to the annotation file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few suggested fixes:
Necessary ones:
Useful ones:
3) worm_cat_fun will not try to create the output_dir unless it doesn't exist - makes it easier to rerun jobs and overwrite results.
4) added option to worm_cat_fun to turn off creating a zipped archive (default behavior is the same as before)