fix: advance to step 2 when manually configuring models in edit endpoint modal#728
Merged
fergusfinn merged 2 commits intomainfrom Feb 19, 2026
Merged
Conversation
…int modal handleConfigureManually in EditEndpointModal was missing the setCurrentStep(2) call that CreateEndpointModal has, so clicking "Next" with auto-discover disabled left users stuck on step 1 with no way to edit models on an existing endpoint. Fixes #550 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
🚅 Deployed to the control-layer-pr-728 environment in industrious-light
|
railway-app
bot
temporarily deployed
to
industrious-light / control-layer-pr-728
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the endpoint editing workflow where users were unable to manually configure models for existing endpoints. When users disabled auto-discovery (necessary for backends like TensorZero that don't support /v1/models), clicking "Next" would enable manual mode but fail to advance the wizard from step 1 to step 2, leaving users stuck with no way to edit models.
Changes:
- Added
setCurrentStep(2)call tohandleConfigureManuallyinEditEndpointModalto match the behavior inCreateEndpointModal
JoshC8C7
approved these changes
Feb 18, 2026
Contributor
JoshC8C7
left a comment
JoshC8C7
left a comment
There was a problem hiding this comment.
if its been tested manually then sounds good
Contributor
Author
|
wdym tested manually haven't you heard of AI |
Previously the field was gated by `requires_api_key`, so endpoints created without a key could never have one added through the edit modal.
railway-app
bot
temporarily deployed
to
industrious-light / control-layer-pr-728
fergusfinn
pushed a commit
that referenced
this pull request
Feb 19, 2026
🤖 I have created a release *beep* *boop* --- ## [8.1.0](v8.0.1...v8.1.0) (2026-02-19) ### Features * make demo mode data more realistic ([#731](#731)) ([17aa9bf](17aa9bf)) ### Bug Fixes * advance to step 2 when manually configuring models in edit endpoint modal ([#728](#728)) ([fdcf360](fdcf360)) * omit Secure attribute from cookies when cookie_secure is false ([#730](#730)) ([e6f936e](e6f936e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handleConfigureManuallyinEditEndpointModalto callsetCurrentStep(2), matching the behavior inCreateEndpointModalRoot cause
EditEndpointModal.handleConfigureManually(line 287) was missingsetCurrentStep(2). The equivalent function inCreateEndpointModal(line 445) includes this call. This meant that when auto-discover was disabled (necessary for non-OpenAI backends like TensorZero that don't serve/v1/models), the "Next" button toggled manual mode but never advanced the wizard step.Test plan
Fixes #550
🤖 Generated with Claude Code