Merged
Conversation
|
🚅 Deployed to the control-layer-pr-711 environment in industrious-light
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates user-facing “completion_window” values from raw duration strings (e.g., "24h", "1h") to priority-oriented display labels (e.g., "Standard (24h)", "High (1h)") across API responses and the dashboard UI, while aiming to preserve backwards-compatible request handling.
Changes:
- Added a backend completion-window formatting/normalization utility and applied formatting to batch/config/tariff-related API responses.
- Updated batch creation flow and multiple UI surfaces to display “Priority” instead of “SLA”, using formatted values from the config API.
- Added documentation for the SLA→Priority terminology migration and updated mocks/tests accordingly.
Reviewed changes
Copilot reviewed 35 out of 36 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| test-requests-gemma.jsonl | Adds example JSONL request payloads for batch/testing. |
| dwctl/src/request_logging/serializers.rs | Updates analytics comment terminology to “priority”. |
| dwctl/src/request_logging/batcher.rs | Updates tariff-selection comments/tests terminology to “priority”. |
| dwctl/src/lib.rs | Updates background-service comment wording around escalation. |
| dwctl/src/db/models/tariffs.rs | Updates tariff model docs from SLA to priority terminology. |
| dwctl/src/db/models/deployments.rs | Updates throughput comment wording for batch capacity. |
| dwctl/src/config.rs | Documents completion window storage vs. user-facing priority naming. |
| dwctl/src/api/models/transactions.rs | Adjusts transaction response docs/logic for batch priority output. |
| dwctl/src/api/models/tariffs.rs | Formats tariff completion_window for API responses. |
| dwctl/src/api/models/mod.rs | Registers new completion_window module. |
| dwctl/src/api/models/files.rs | Updates file cost-estimate query doc wording. |
| dwctl/src/api/models/deployments/mod.rs | Updates deployment/tariff schema docs to priority terminology. |
| dwctl/src/api/models/completion_window.rs | New module for formatting + normalization of completion windows. |
| dwctl/src/api/models/batches.rs | Updates batch request/response schema examples and adds custom deserializer. |
| dwctl/src/api/handlers/sla_capacity.rs | Renames/updates SLA capacity wording to completion-window capacity. |
| dwctl/src/api/handlers/queue.rs | Updates queue docs from SLA to priority terminology. |
| dwctl/src/api/handlers/files.rs | Updates comments (but cost-estimate behavior unchanged). |
| dwctl/src/api/handlers/deployments.rs | Adds completion_window normalization when creating/updating tariffs. |
| dwctl/src/api/handlers/config.rs | Formats allowed_completion_windows in config responses. |
| dwctl/src/api/handlers/batches.rs | Formats batch completion_window in responses; adds normalization + tests. |
| docs/SLA_TO_PRIORITY_MIGRATION.md | Adds detailed migration guide and compatibility notes. |
| docs/SCOUTER.md | Updates docs wording from SLA to priority. |
| dashboard/src/components/modals/UpdateModelPricingModal/UpdateModelPricingModal.tsx | Updates default allowed completion windows fallback. |
| dashboard/src/components/modals/CreateBatchModal/CreateBatchModal.tsx | Switches UI to priority labels and uses config-provided values. |
| dashboard/src/components/modals/CreateBatchModal/CreateBatchModal.test.tsx | Updates tests for new formatted completion-window values. |
| dashboard/src/components/features/requests/RequestsAnalytics/RequestsAnalytics.tsx | Updates UI labels/help text from SLA to priority. |
| dashboard/src/components/features/models/Models/ModelsContent.tsx | Adjusts display of tariff completion_window in models list. |
| dashboard/src/components/features/models/ModelTariffTable/ModelTariffTable.tsx | Updates priority display + default naming behavior for batch tariffs. |
| dashboard/src/components/features/cost-management/CostManagement/TransactionHistory.tsx | Updates batch transaction description wording/formatting. |
| dashboard/src/components/features/batches/BatchesTable/columns.tsx | Renames SLA column header to Priority. |
| dashboard/src/components/features/batches/BatchInfo/BatchInfo.tsx | Displays priority label instead of raw completion window. |
| dashboard/src/api/control-layer/types.ts | Updates type comments and adds a BatchPriority type (needs alignment). |
| dashboard/src/api/control-layer/mocks/handlers.ts | Updates mock config allowed_completion_windows to formatted labels. |
| dashboard/src/api/control-layer/mocks/batches.json | Updates mock batch completion_window values to formatted labels. |
| dashboard/public/bootstrap.js | Updates bootstrap UI copy (“SLA” → “Priority”) and removes glow/dot styling. |
| Cargo.lock | Bumps dwctl crate version. |
Changes all API responses to return user-friendly priority labels
("Standard (24h)", "High (1h)") instead of raw time values ("24h", "1h").
API requests continue to accept both formats for backwards compatibility.
- Config endpoint formats allowed_completion_windows array
- Batch API responses format completion_window field
- Tariff API responses format completion_window field
- Frontend displays formatted values from API
- Tariff name generation simplified to use priority label directly
- Removed technical tooltip from batch submission UI
cc5641a to
3016059
Compare
- Extend normalization to accept bare priority names ('high', 'standard')
- Remove duplicate normalization function from batches handler
- Use shared completion_window utility consistently across codebase
- Fix error messages to use formatted priority labels
- Update TypeScript type documentation to reflect formatted values
- Fix transactions API to return formatted labels consistently
Previously the update path only handled bare 'high'/'standard' names and would pass through formatted labels like 'Standard (24h)' unchanged, risking DB corruption. Now uses normalize_completion_window() for all formats.
Bare names ('high', 'standard') remain supported in the API for
backwards compatibility but are not documented or promoted.
Changes:
- Update all comments to reference formatted labels ('Standard (24h)')
- Update API examples to use formatted labels instead of raw values
- Clarify error messages to not mention bare names
- Fix outdated frontend comment about capitalizing bare names
- Mark bare name support as 'legacy' in implementation comments
- Update tariffs schema to show formatted examples ("Standard (24h)")
- Extract raw completion window for cost estimate API calls
- Fix reset fallback to use formatted value instead of raw "24h"
All frontend tests passing (384/384)
- Display "Batch - Standard (24h)" instead of "Batch (Standard (24h))" in tariff table API Key Purpose column - Show priority values as-is without redundant formatting in Priority column - Abbreviate priority on model cards to "Standard:" instead of "Standard (24h):" to fit card width - Format transaction names as "API Batch - Standard (24h)" instead of "Batch (API - Standard (24h))" - Update migration documentation with new display formats These changes eliminate nested parentheses and improve readability while keeping all information visible through tooltips. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Automated formatting changes from running Prettier on the codebase. No functional changes - only whitespace, line breaks, and code style formatting. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update first_batch.html email template to use 'priority level' instead of 'SLA' - Add dwctl/emails/ to .gitignore (generated email files for testing) - Remove generated .eml file from git tracking Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dashboard/src/components/features/batches/BatchInfo/BatchInfo.tsx
Outdated
Show resolved
Hide resolved
dashboard/src/components/features/models/Models/ModelsContent.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
pjb157
added a commit
that referenced
this pull request
Feb 17, 2026
🤖 I have created a release *beep* *boop* --- ## [8.0.0](v7.5.1...v8.0.0) (2026-02-17) ### ⚠ BREAKING CHANGES * move from SLA to Priority ([#711](#711)) ### Features * add OpenAPI docs for Responses API ([#713](#713)) ([ec3a49b](ec3a49b)) * move from SLA to Priority ([#711](#711)) ([1ee7f63](1ee7f63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces raw time values with formatted priority labels in all API responses:
Changes
Backend:
allowed_completion_windowscompletion_windowfieldFrontend:
Breaking Change
completion_window === "24h"will need to update to check for"Standard (24h)".API requests continue to accept both formats.
Testing