fix: observe AVPlayerItem.status for HLS streaming auto-start#101
Open
tahakocal wants to merge 1 commit intodoublesymmetry:mainfrom
Open
fix: observe AVPlayerItem.status for HLS streaming auto-start#101tahakocal wants to merge 1 commit intodoublesymmetry:mainfrom
tahakocal wants to merge 1 commit intodoublesymmetry:mainfrom
Conversation
When playing HLS streams, audio doesn't start on first play() call because AVPlayerItem.status is still .unknown at that point. AVPlayer ignores rate changes when item is not ready. This fix adds observation of AVPlayerItem.status. When status becomes .readyToPlay and playWhenReady is true, we call applyAVPlayerRate() to start playback. Problem: 1. play() is called -> playWhenReady = true 2. applyAVPlayerRate() sets rate, but item.status is .unknown 3. AVPlayer ignores the rate change 4. Item becomes .readyToPlay but nothing triggers playback 5. Audio doesn't play until pause/play cycle Solution: 1. Observe AVPlayerItem.status changes 2. When status becomes .readyToPlay and playWhenReady is true 3. Call applyAVPlayerRate() to start actual playback This is consistent with Apple's guidance from WWDC 2016: "Observe the status property of AVPlayerItem and only begin playback when status is .readyToPlay" Fixes HLS streams not auto-starting on iOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When playing HLS (m3u8) streams, audio doesn't start automatically on the first play() call. The player reports a "playing" state, but no audio is heard. Pausing and playing again makes audio work.
Root Cause
When play() is called:
Later, when the item becomes ready (status = .readyToPlay), nothing triggers playback because status changes were not being observed.
Solution
This PR adds observation of AVPlayerItem.status:
Why This Works
Timeline before fix:
play() called → playWhenReady=true → applyRate() → item.status=.unknown → ❌ No audio
Timeline after fix:
play() called → playWhenReady=true → applyRate() → item.status=.unknown → (no audio yet)
→ item.status=.readyToPlay → applyRate() → ✅ Audio plays!
Testing
Tested with:
References
From Apple's WWDC 2016 session on AVFoundation:
"You should observe the status property of AVPlayerItem and only begin playback when status is .readyToPlay"