Add docker support (closes #26) #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xZero707
commented
Dec 29, 2025
Author
There was a problem hiding this comment.
Not required, but recommended optimisation as it ensures that the context sent to Docker is minimal. Depending on the repository, this might have a huge impact.
xZero707
commented
Dec 29, 2025
xZero707
commented
Dec 29, 2025
xZero707
commented
Dec 29, 2025
xZero707
commented
Dec 29, 2025
| "linux/386") BBKCLI_ARCH=i386 ;; \ | ||
| esac \ | ||
| && echo "Fetch: https://frontend.bredbandskollen.se/download/bbk_cli_linux_${BBKCLI_ARCH:-amd64}-${BBKCLI_VERSION}" \ | ||
| && wget -q https://frontend.bredbandskollen.se/download/bbk_cli_linux_${BBKCLI_ARCH:-amd64}-${BBKCLI_VERSION} -O /bbk_cli |
Author
There was a problem hiding this comment.
Uses prebuilt library. I can change it to build from source, if desired.
Is there maybe a hash file to validate binary integrity?
xZero707
commented
Dec 29, 2025
|
|
||
| LABEL org.opencontainers.image.title="Bredbandskollen CLI" \ | ||
| org.opencontainers.image.description="Bredbandskollen CLI, a bandwidth measurement tool" \ | ||
| org.opencontainers.image.authors="The Swedish Internet Foundation <support@bredbandskollen.se>" \ |
Author
There was a problem hiding this comment.
I don't know what to put here. Please validate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I submit this pull request as a complete package, and I can adapt it accordingly to your preferences.
Included components:
docker buildx bake --file hack/docker-bake.hclDockerfileitselfBy default, only
ghcr.iois used as image registry, but that can be adjusted (eg. add offical docker registry).This closes #26.
Happy New Year!