-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix visibility logic for addNewPanel in DesignBindingPicker to use _dataSourceProviderService #14133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix visibility logic for addNewPanel in DesignBindingPicker to use _dataSourceProviderService #14133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the visibility logic for the _addNewPanel in the DesignBindingPicker control to properly respect the data source provider service's capabilities. The change restores behavior that aligns with .NET Framework by ensuring the "Add new Object Data Source" panel only appears when the data source provider service is available and supports adding new data sources.
Key Changes
- Re-enabled the previously commented-out visibility logic for _addNewPanel in the Pick method
- Updated the variable reference from the non-existent
dspSvcto the correct field_dataSourceProviderService
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignBindingPicker.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignBindingPicker.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/Windows/Forms/Design/DesignBindingPicker.cs
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14133 +/- ##
===================================================
+ Coverage 76.01271% 77.16231% +1.14960%
===================================================
Files 3279 3279
Lines 645325 645328 +3
Branches 47720 47721 +1
===================================================
+ Hits 490529 497950 +7421
+ Misses 145491 143695 -1796
+ Partials 9305 3683 -5622
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ricardobossan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All LGTM!
Fixes #14132
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
The "Add new Object Data Source" link & description shouldn't display in the DropDown panel for the DataSource & DisplayMember properties in the propertiGird
After
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow