Closed
Conversation
ghost
added
Area-AspNetCore
Contributor
|
Thanks for your PR, @jjonescz. |
|
Any news for this PR seems like a nice feature |
Member
Author
Once we want to introduce a new warning that would break existing code, we would use this feature for it, but currently we don't. |
Contributor
|
Due to lack of recent activity, this PR has been labeled as 'Stale'. It will be closed if no further activity occurs within 7 more days. Any new comment will remove the label. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for RazorWarningLevel (similar to C# WarningLevel) - so the razor compiler can report new warnings on existing code and users will be able to turn those warnings off to avoid breaking their builds.
Related to dotnet/razor#10346.
I plan to add a test once razor official builds work again so I can flow a razor build here to test it in CI.