[Wasm R2R] Allow LDVIRTFTN call sigs to carry a type arg (MD array methods)#129064
Open
AndyAyersMS wants to merge 1 commit into
Open
[Wasm R2R] Allow LDVIRTFTN call sigs to carry a type arg (MD array methods)#129064AndyAyersMS wants to merge 1 commit into
AndyAyersMS wants to merge 1 commit into
Conversation
…thods) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@davidwrighton PTAL Fixes some more pri-0 test issues (case 3 here: #128234 (comment)) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts a debug-only invariant in the ReadyToRun JIT interface to account for WebAssembly’s virtual-call lowering behavior: Wasm forces virtual calls down the LDVIRTFTN path (since stub dispatch is unsupported), and those call signatures can legitimately include a hidden type parameter (e.g., for MD-array intrinsic handling).
Changes:
- Relax
Debug.Assertin theCORINFO_VIRTUALCALL_LDVIRTFTNhandling to allowsig.hasTypeArg()on Wasm targets. - Add clarifying comments explaining why Wasm is allowed to carry a type arg and where
instParamLookupis established.
Member
Author
|
We might be able to avoid this in the JIT, or scope the relaxed assert more tightly to MD array methods... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.