Skip to content

[Wasm RyuJit] Match how other targets consume initblk fill values #129062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyAyersMS wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

[Wasm RyuJit] Match how other targets consume initblk fill values #129062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/coreclr/jit/codegenwasm.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3093,7 +3093,12 @@ void CodeGen::genCodeForStoreBlk(GenTreeBlk* blkOp)
unsigned destOffset = 0;
unsigned srcOffset = 0;

genConsumeOperands(blkOp);
// Unwrap a contained GT_INIT_VAL so the wrapped fill value (not the wrapper) is pushed onto the WASM value stack.
GenTree* srcForConsume = src->OperIs(GT_INIT_VAL) ? src->gtGetOp1() : src;
assert(!src->OperIs(GT_INIT_VAL) || src->isContained());

genConsumeRegs(dest);
genConsumeRegs(srcForConsume);

// If the source is a byref or pointer it will be a GT_IND that we need to unwrap to extract the
// actual address we're loading from. Note that this does not apply to the destination.
Expand Down
Loading