JIT: remove optCanProp* short-circuit flags#128924
Merged
Merged
Conversation
github-actions
Bot
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the optCanProp* short-circuit flags from JIT assertion propagation, simplifying state tracking and treating the prior “can propagate” checks as always enabled.
Changes:
- Deletes
optCanPropLclVar/Equal/NonNull/BndsChk/SubRangefields fromCompiler. - Removes initialization and update logic for those flags in assertion table construction.
- Drops the corresponding early-return guards in assertion propagation helpers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/compiler.h | Removes the optCanProp* state fields from Compiler. |
| src/coreclr/jit/assertionprop.cpp | Removes flag initialization/maintenance and the related early-exit checks in assertion propagation helpers. |
EgorBo
force-pushed
the
remove-optcanprop-flags
branch
from
7a90abc to
9de0b41
Compare
EgorBo
force-pushed
the
remove-optcanprop-flags
branch
from
9de0b41 to
67f0de3
Compare
EgorBo
force-pushed
the
remove-optcanprop-flags
branch
from
67f0de3 to
6919358
Compare
EgorBo
force-pushed
the
remove-optcanprop-flags
branch
from
6919358 to
45d7680
Compare
Member
Author
|
PTAL @jakobbotsch (I recommend disabling the whitespaces in the review tab) @dotnet/jit-contrib Some improvements in diffs along the way - mostly becase some functions were gated by one short-circut flag but actually used more than 1 type of assertions. |
jakobbotsch
approved these changes
Jun 3, 2026
Member
Author
|
/ba-g known build break in CSharpMissingShebangInFileBasedProgram #128905 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128602
Also, a potential correctness issue with stale assertions after local assert prop or JitOptRepeat
Also, removes a bunch of short-circuit flags that do not actually improve TP