Skip to content

Initialize *ppv in comhost DllGetClassObject #128916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Initialize *ppv in comhost DllGetClassObject #128916

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25c7651
Initial plan
Copilot Jun 2, 2026
f0a4712
Initialize *ppv in DllGetClassObject
Copilot Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/native/corehost/comhost/comhost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,12 @@ COM_API HRESULT STDMETHODCALLTYPE DllGetClassObject(
_In_ REFIID riid,
_Outptr_ LPVOID FAR* ppv)
{
if (ppv == nullptr)
return E_POINTER;

// COM out parameters must always be initialized, including on failure paths.
*ppv = nullptr;
Comment thread
AaronRobinsonMSFT marked this conversation as resolved.

// Check if the CLSID map contains a mapping
clsid_map map;
RETURN_HRESULT_IF_EXCEPT(map = comhost::get_clsid_map());
Expand Down
Loading