[Android] Disable X509 name-constraint violation tests on Android#128892
Open
Copilot wants to merge 2 commits into
Open
[Android] Disable X509 name-constraint violation tests on Android#128892Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix X509 DynamicChainTests name-constraint status mismatch
Mark Android X509 name-constraint failures active
Jun 2, 2026
This was referenced Jun 2, 2026
Contributor
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
simonrozsival
changed the title
simonrozsival
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the System.Security.Cryptography X509 chain-building test suite to acknowledge known Android-only failures in DynamicChainTests around name-constraint violation handling, by marking the affected tests with ActiveIssue so they’re skipped on Android while continuing to run on other platforms.
Changes:
- Added
[ActiveIssue("https://github.com/dotnet/runtime/issues/128890", TestPlatforms.Android)]to the DNS permitted/excluded name-constraint violation tests. - Added the same Android-scoped
ActiveIssueto the UPN permitted/excluded name-constraint violation tests (including oneConditionalFactcase). - Kept all non-Android behavior and coverage unchanged.
Show a summary per file
| File | Description |
|---|---|
src/libraries/System.Security.Cryptography/tests/X509Certificates/DynamicChainTests.cs |
Marks four Android-failing name-constraint violation tests as ActiveIssue to prevent Android CI failures while preserving coverage elsewhere. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Member
|
/azp run runtime-android |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vcsjones
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android X.509 chain building reports different name-constraint outcomes than the current
DynamicChainTestsexpectations on Helix hardware. The mismatch affects the permitted/excluded DNS and UPN violation cases across Android CoreCLR/Mono legs.ActiveIssue.Related to #128890