Skip to content

EmccCompile: prefer TryRunProcess over RunShellCommand.#126150

Open
tmds wants to merge 2 commits intodotnet:mainfrom
tmds:emcc-use-tryrunprocess
Open

EmccCompile: prefer TryRunProcess over RunShellCommand.#126150
tmds wants to merge 2 commits intodotnet:mainfrom
tmds:emcc-use-tryrunprocess

Conversation

@tmds
Copy link
Member

@tmds tmds commented Mar 26, 2026

A shell is not needed to run emcc.

@tmds tmds requested review from akoeplinger and maraf as code owners March 26, 2026 12:54
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 26, 2026
@maraf
Copy link
Member

maraf commented Mar 27, 2026

Thank you @tmds for the contribution!

There are test failures related to the change

src\mono\wasm\build\WasmApp.Common.targets(868,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Failed to compile D:\a\_work\1\s\artifacts\bin\microsoft.netcore.app.runtime.browser-wasm\Release\runtimes\browser-wasm\native\src\driver.c -> D:\a\_work\1\s\artifacts\obj\System.Diagnostics.Tracing.Tests\Release\net11.0-browser\browser-wasm\wasm\for-publish\driver.o
An error occurred trying to start process 'D:\a\_work\1\s\src\mono\browser\emsdk\emscripten\emcc' with working directory 'D:\a\_work\1\s\src\libraries\System.Diagnostics.Tracing\tests'. The specified executable is not a valid application for this OS platform.

https://github.com/dotnet/runtime/pull/126150/checks?check_run_id=68749851592

Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking if there wasn't reason to put the command in batch file, something like too long input

@maraf maraf added arch-wasm WebAssembly architecture os-browser Browser variant of arch-wasm labels Mar 27, 2026
@maraf maraf added this to the 11.0.0 milestone Mar 27, 2026
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara
See info in area-owners.md if you want to be subscribed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arch-wasm WebAssembly architecture area-Build-mono community-contribution Indicates that the PR has been added by a community member os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants