EmccCompile: prefer TryRunProcess over RunShellCommand.#126150
Open
tmds wants to merge 2 commits intodotnet:mainfrom
Open
EmccCompile: prefer TryRunProcess over RunShellCommand.#126150tmds wants to merge 2 commits intodotnet:mainfrom
tmds wants to merge 2 commits intodotnet:mainfrom
Conversation
A shell is not needed to run emcc.
am11
reviewed
Mar 26, 2026
Member
|
Thank you @tmds for the contribution! There are test failures related to the change https://github.com/dotnet/runtime/pull/126150/checks?check_run_id=68749851592 |
maraf
reviewed
Mar 27, 2026
Member
maraf
left a comment
There was a problem hiding this comment.
I'm thinking if there wasn't reason to put the command in batch file, something like too long input
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shell is not needed to run emcc.