Skip to content

[release/9.0-staging] Fix missing release semantics in VolatilePtr #124119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: release/9.0-staging
Choose a base branch
from
+23 −0
Open

[release/9.0-staging] Fix missing release semantics in VolatilePtr #124119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/coreclr/gc/env/volatile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,16 @@ class VolatilePtr : public Volatile<P>
{
}

//
// Bring the base class operator= into scope.
//
using Volatile<P>::operator=;

//
// Copy assignment operator.
//
inline VolatilePtr<T,P>& operator=(const VolatilePtr<T,P>& other) {this->Store(other.Load()); return *this;}

//
// Cast to the pointer type
//
Expand Down
13 changes: 13 additions & 0 deletions src/coreclr/inc/volatile.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,6 +517,19 @@ class VolatilePtr : public Volatile<P>
STATIC_CONTRACT_SUPPORTS_DAC;
}

//
// Bring the base class operator= into scope. Without this, the compiler-generated
// copy assignment operator hides Volatile<P>::operator= and performs a plain store,
// bypassing the memory barriers provided by VolatileStore.
//
using Volatile<P>::operator=;

//
// Copy assignment operator. The using declaration above does not suppress the
// compiler-generated copy assignment, so we must define it explicitly.
//
inline VolatilePtr<T,P>& operator=(const VolatilePtr<T,P>& other) {this->Store(other.Load()); return *this;}

//
// Cast to the pointer type
//
Expand Down
Loading