Skip to content

Skip PROCAbortInitialize on WASM#124104

Open
steveisok wants to merge 3 commits intodotnet:mainfrom
steveisok:fix-wasm-minidump-init
Open

Skip PROCAbortInitialize on WASM#124104
steveisok wants to merge 3 commits intodotnet:mainfrom
steveisok:fix-wasm-minidump-init

Conversation

@steveisok
Copy link
Member

Mini dumps are not supported on WASM - the createdump binary doesn't exist and the browser environment doesn't support crash dumps.

Setting DOTNET_DbgEnableMiniDump=1 was causing runtime init to fail because PROCAbortInitialize depends on g_szCoreCLRPath which is never set on WASM (LOADInitializeCoreCLRModule is already skipped).

Fixes #124088

Mini dumps are not supported on WASM - the createdump binary doesn't
exist and the browser environment doesn't support crash dumps.

Setting DOTNET_DbgEnableMiniDump=1 was causing runtime init to fail
because PROCAbortInitialize depends on g_szCoreCLRPath which is never
set on WASM (LOADInitializeCoreCLRModule is already skipped).

Fixes dotnet#124088
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents CoreCLR runtime initialization from failing on WebAssembly when DOTNET_DbgEnableMiniDump=1 is set, by skipping PROCAbortInitialize() on TARGET_WASM where minidumps/createdump aren’t supported and g_szCoreCLRPath is not initialized.

Changes:

  • Wrap the PROCAbortInitialize() call in PAL_InitializeCoreCLR with #ifndef TARGET_WASM to avoid failing startup on WASM.

Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
Copilot AI review requested due to automatic review settings February 6, 2026 20:33
Co-authored-by: Radek Doulik <radek.doulik@gmail.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[wasm][browser] runtime init fails with DOTNET_DbgEnableMiniDump=1

2 participants