Rename runtime-async contract types and methods to follow framework guidelines#124097
Draft
Rename runtime-async contract types and methods to follow framework guidelines#124097
Conversation
- Renamed ExecutionAndSyncBlockStore to ExecutionContextSnapshot - Renamed FinalizeTaskReturningThunk/FinalizeValueTaskReturningThunk to CreateAsyncMethodTask/CreateAsyncMethodValueTask - Renamed CompletedTask to ValidateCompletedTask - Renamed CompletedTaskResult to GetCompletedTaskResult - Updated all references in C#, C++, and TypeSystem code Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Update METHOD definitions to reference EXECUTIONCONTEXTSNAPSHOT instead of EXECUTIONANDSYNCBLOCKSTORE Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update types and methods in AsyncHelpers for clarity
Rename runtime-async contract types and methods to follow framework guidelines
Feb 6, 2026
Member
|
@copilot Rename |
Updated all references across C#, C++, and TypeSystem code per reviewer feedback Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
Contributor
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Runtime-async contract types and methods become immutable once baked into ReadyToRun images. The original names were implementation-focused and unclear for a public-facing contract.
Changes
Renamed three core runtime-async contract elements across C#, C++, and IL generation code:
ExecutionAndSyncBlockStore→AsyncContextsSnapshotFinalizeTaskReturningThunk[<T>]→CreateAsyncMethodTask[<T>]FinalizeValueTaskReturningThunk[<T>]→CreateAsyncMethodValueTask[<T>]Task.FromResult)CompletedTask(Result)→ValidateCompletedTask/GetCompletedTaskResult<T>GetResult()patternUpdated references in:
AsyncHelpers.CoreCLR.cs(managed implementations)corelib.h(VM type/method definitions)asyncthunks.cpp(thunk generation)AsyncThunks.cs(NativeAOT IL stubs)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.