Use sln format for coreclr and corehost#115935
Merged
ViktorHofer merged 2 commits intomainfrom May 23, 2025
Merged
Conversation
Merged
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build script to use the .sln format for both coreclr and corehost instead of the previous .slnx format.
- Updated help message examples to reflect the new .sln format.
- Changed conditionals and file path constructions to generate and reference .sln files for both coreclr and corehost.
| Write-Host " -vs Open the solution with Visual Studio using the locally acquired SDK." | ||
| Write-Host " Path or any project or solution name is accepted." | ||
| Write-Host " (Example: -vs Microsoft.CSharp or -vs CoreCLR.slnx)" | ||
| Write-Host " (Example: -vs Microsoft.CSharp or -vs CoreCLR.sln)" |
There was a problem hiding this comment.
Ensure that the help message example is consistent with the updated solution file generation logic across the script.
Contributor
|
Tagging subscribers to this area: @hoyosjs |
jakobbotsch
approved these changes
May 23, 2025
Member
|
Thanks for fixing this quickly! |
Member
Author
|
/ba-g these changes aren't exercised in CI |
SimaTian
pushed a commit
that referenced
this pull request
May 27, 2025
* Use sln format for coreclr and corehost * Update Program.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up on #115818