Fix GetDeconstructionInfo on converted deconstruction assignment#82324
Merged
jcouv merged 4 commits intodotnet:mainfrom Feb 14, 2026
Merged
Fix GetDeconstructionInfo on converted deconstruction assignment#82324jcouv merged 4 commits intodotnet:mainfrom
GetDeconstructionInfo on converted deconstruction assignment#82324jcouv merged 4 commits intodotnet:mainfrom
Conversation
added 2 commits
February 6, 2026 15:08
AlekseyTs
reviewed
Feb 11, 2026
| var boundDeconstruction = GetUpperBoundNode(node) as BoundDeconstructionAssignmentOperator; | ||
| if (boundDeconstruction is null) | ||
| var upperNode = GetUpperBoundNode(node); | ||
| while (upperNode is BoundConversion conversion) |
Contributor
Contributor
There was a problem hiding this comment.
Would requesting the "lower" bound node work better?
Member
Author
There was a problem hiding this comment.
Would requesting the "lower" bound node work better?
Yes, I think that's better. Thanks
Could you provide more details about the tree shape that we are trying to accommodate with this change?
Here's the shape of the tree:
The bound node for the RHS assignment syntax is a conversion chain with a deconstructionAssignmentOperator.
Here's an extract:
│ └─assignmentOperator
│ ├─left
│ │ └─local
│ │ ├─localSymbol: c1
│ │ ├─declarationKind: None
│ │ ├─constantValueOpt
│ │ ├─isNullableUnknown: False
│ │ └─type: C
│ ├─right
│ │ └─conversion
│ │ ├─operand
│ │ │ └─conversion
│ │ │ ├─operand
│ │ │ │ └─deconstructionAssignmentOperator
Here's the full:
nonConstructorMethodBody
├─blockBody
│ └─block
│ ├─locals: {c1, c2}
│ ├─hasUnsafeModifier: False
│ ├─instrumentation
│ └─statements
│ ├─localDeclaration
│ │ ├─localSymbol: c1
│ │ ├─declaredTypeOpt
│ │ │ └─typeExpression
│ │ │ ├─typeWithAnnotations: C
│ │ │ └─type: C
│ │ ├─initializerOpt
│ │ │ └─objectCreationExpression
│ │ │ ├─constructor: C.C()
│ │ │ ├─constructorsGroup: {C.C()}
│ │ │ ├─arguments
│ │ │ ├─argumentNamesOpt: (null)
│ │ │ ├─argumentRefKindsOpt: (null)
│ │ │ ├─expanded: False
│ │ │ ├─argsToParamsOpt: (null)
│ │ │ ├─defaultArguments: Microsoft.CodeAnalysis.BitVector
│ │ │ ├─constantValueOpt
│ │ │ ├─initializerExpressionOpt
│ │ │ ├─wasTargetTyped: False
│ │ │ └─type: C
│ │ ├─argumentsOpt
│ │ └─inferredType: True
│ ├─localDeclaration
│ │ ├─localSymbol: c2
│ │ ├─declaredTypeOpt
│ │ │ └─typeExpression
│ │ │ ├─typeWithAnnotations: C
│ │ │ └─type: C
│ │ ├─initializerOpt
│ │ │ └─objectCreationExpression
│ │ │ ├─constructor: C.C()
│ │ │ ├─constructorsGroup: {C.C()}
│ │ │ ├─arguments
│ │ │ ├─argumentNamesOpt: (null)
│ │ │ ├─argumentRefKindsOpt: (null)
│ │ │ ├─expanded: False
│ │ │ ├─argsToParamsOpt: (null)
│ │ │ ├─defaultArguments: Microsoft.CodeAnalysis.BitVector
│ │ │ ├─constantValueOpt
│ │ │ ├─initializerExpressionOpt
│ │ │ ├─wasTargetTyped: False
│ │ │ └─type: C
│ │ ├─argumentsOpt
│ │ └─inferredType: True
│ └─expressionStatement
│ └─expression
│ └─assignmentOperator
│ ├─left
│ │ └─local
│ │ ├─localSymbol: c1
│ │ ├─declarationKind: None
│ │ ├─constantValueOpt
│ │ ├─isNullableUnknown: False
│ │ └─type: C
│ ├─right
│ │ └─conversion
│ │ ├─operand
│ │ │ └─conversion
│ │ │ ├─operand
│ │ │ │ └─deconstructionAssignmentOperator
│ │ │ │ ├─left
│ │ │ │ │ └─convertedTupleLiteral
│ │ │ │ │ ├─sourceTuple
│ │ │ │ │ │ └─tupleLiteral
│ │ │ │ │ │ ├─arguments
│ │ │ │ │ │ │ ├─discardExpression
│ │ │ │ │ │ │ │ ├─nullableAnnotation: Oblivious
│ │ │ │ │ │ │ │ ├─isInferred: True
│ │ │ │ │ │ │ │ └─type: int
│ │ │ │ │ │ │ └─discardExpression
│ │ │ │ │ │ │ ├─nullableAnnotation: Oblivious
│ │ │ │ │ │ │ ├─isInferred: True
│ │ │ │ │ │ │ └─type: string
│ │ │ │ │ │ ├─argumentNamesOpt: (null)
│ │ │ │ │ │ ├─inferredNamesOpt: (null)
│ │ │ │ │ │ └─type: (int, string)
│ │ │ │ │ ├─wasTargetTyped: False
│ │ │ │ │ ├─arguments
│ │ │ │ │ │ ├─discardExpression
│ │ │ │ │ │ │ ├─nullableAnnotation: Oblivious
│ │ │ │ │ │ │ ├─isInferred: True
│ │ │ │ │ │ │ └─type: int
│ │ │ │ │ │ └─discardExpression
│ │ │ │ │ │ ├─nullableAnnotation: Oblivious
│ │ │ │ │ │ ├─isInferred: True
│ │ │ │ │ │ └─type: string
│ │ │ │ │ ├─argumentNamesOpt: (null)
│ │ │ │ │ ├─inferredNamesOpt: (null)
│ │ │ │ │ └─type: (int, string)
│ │ │ │ ├─right
│ │ │ │ │ └─conversion
│ │ │ │ │ ├─operand
│ │ │ │ │ │ └─local
│ │ │ │ │ │ ├─localSymbol: c2
│ │ │ │ │ │ ├─declarationKind: None
│ │ │ │ │ │ ├─constantValueOpt
│ │ │ │ │ │ ├─isNullableUnknown: False
│ │ │ │ │ │ └─type: C
│ │ │ │ │ ├─conversion: Deconstruction
│ │ │ │ │ ├─isBaseConversion: False
│ │ │ │ │ ├─@checked: False
│ │ │ │ │ ├─explicitCastInCode: False
│ │ │ │ │ ├─constantValueOpt
│ │ │ │ │ ├─conversionGroupOpt
│ │ │ │ │ ├─inConversionGroupFlags: Unspecified
│ │ │ │ │ └─type: (int, string)
│ │ │ │ ├─isUsed: True
│ │ │ │ └─type: (int, string)
│ │ │ ├─conversion: Identity
│ │ │ ├─isBaseConversion: False
│ │ │ ├─@checked: False
│ │ │ ├─explicitCastInCode: False
│ │ │ ├─constantValueOpt
│ │ │ ├─conversionGroupOpt: Microsoft.CodeAnalysis.CSharp.ConversionGroup
│ │ │ ├─inConversionGroupFlags: UserDefinedFromConversion
│ │ │ └─type: (int i, string s)
│ │ ├─conversion: ImplicitUserDefined
│ │ ├─isBaseConversion: False
│ │ ├─@checked: False
│ │ ├─explicitCastInCode: False
│ │ ├─constantValueOpt
│ │ ├─conversionGroupOpt: Microsoft.CodeAnalysis.CSharp.ConversionGroup
│ │ ├─inConversionGroupFlags: UserDefinedOperator
│ │ └─type: C
│ └─type: C
└─expressionBody
Contributor
|
Done with review pass (commit 2) |
jcouv
changed the title
GetDeconstructionInfo should dig through conversionsGetDeconstructionInfo should look through conversions
AlekseyTs
reviewed
Feb 12, 2026
| { | ||
| var boundDeconstruction = GetUpperBoundNode(node) as BoundDeconstructionAssignmentOperator; | ||
| if (boundDeconstruction is null) | ||
| var upperNode = GetLowerBoundNode(node); |
Contributor
Contributor
|
Done with review pass (commit 3) |
Contributor
|
@jcouv Consider adjusting the title to reflect the nature of the change |
Member
Author
|
@dotnet/roslyn-compiler for another review. Thanks |
Member
Author
I think " |
Contributor
I don't think I agree. The problem being solved is to look at the right node. |
Contributor
|
And the change, as it stands right now, is not looking through conversions |
jcouv
changed the title
GetDeconstructionInfo should look through conversionsGetDeconstructionInfo on converted deconstruction assignment
333fred
approved these changes
Feb 13, 2026
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #68979