Skip to content

[dotnet] Add new mlaunch 1.1.127 assemblies to SignList.xml#25745

Open
dalexsoto wants to merge 1 commit into
xcode27.0from
dev/alex/xc27signing
Open

[dotnet] Add new mlaunch 1.1.127 assemblies to SignList.xml#25745
dalexsoto wants to merge 1 commit into
xcode27.0from
dev/alex/xc27signing

Conversation

@dalexsoto

Copy link
Copy Markdown
Member

The mlaunch bump from 1.1.113 to 1.1.127 (Xcode 27.0 Beta 1 baseline, #25729) added new assemblies to mlaunch.app/Contents/MonoBundle: the Microsoft.Testing.Platform managed assembly + localized satellites, and a few architecture-specific (R2R) runtime assemblies under .xamarin// (System.ComponentModel, System.Private.Xml.Linq, System.Text.Encodings.Web, System.Threading and System.Xml.Linq).

These new files are not classified in SignList.xml, so the MicroBuild signing step in the "Prepare .NET Release" stage fails with "unknown files which should be signed" (HandleUnmappedFiles=fail).

Add the 7 new assemblies as FirstParty so they are signed, consistent with the rest of the mlaunch.app MonoBundle content.

The mlaunch bump from 1.1.113 to 1.1.127 (Xcode 27.0 Beta 1 baseline,
#25729) added new assemblies to mlaunch.app/Contents/MonoBundle: the
Microsoft.Testing.Platform managed assembly + localized satellites, and a
few architecture-specific (R2R) runtime assemblies under .xamarin/<rid>/
(System.ComponentModel, System.Private.Xml.Linq, System.Text.Encodings.Web,
System.Threading and System.Xml.Linq).

These new files are not classified in SignList.xml, so the MicroBuild
signing step in the "Prepare .NET Release" stage fails with "unknown files
which should be signed" (HandleUnmappedFiles=fail).

Add the 7 new assemblies as FirstParty so they are signed, consistent with
the rest of the mlaunch.app MonoBundle content.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the signing manifest to classify newly introduced mlaunch.app managed assemblies as FirstParty, ensuring the MicroBuild signing step doesn’t fail due to unmapped files after the Microsoft.Tools.Mlaunch NuGet bump.

Changes:

  • Add Microsoft.Testing.Platform (and its .resources) assemblies to FirstParty.
  • Add additional runtime assemblies (System.*) introduced under .xamarin/<rid>/ to FirstParty.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #4576007] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 45760070afe9293a037da44b4293aedc6b26a26a [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #4576007] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 45760070afe9293a037da44b4293aedc6b26a26a [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 45760070afe9293a037da44b4293aedc6b26a26a [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ [PR Build #4576007] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 45760070afe9293a037da44b4293aedc6b26a26a [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #4576007] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 2 tests failed, 206 tests passed.

Failures

❌ linker tests (iOS)

1 tests failed, 14 tests passed.

Failed tests

  • link all/iOS - simulator/Debug (don't bundle original resources): Failed

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

1 tests failed, 18 tests passed.

Failed tests

  • monotouch-test/iOS - simulator/Release (link all): Failed

Html Report (VSDrops) Download

Successes

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 8 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 24 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 24 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 19 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 45760070afe9293a037da44b4293aedc6b26a26a [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants